-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix handling cli options default value #1092
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1092 +/- ##
==========================================
+ Coverage 72.92% 72.95% +0.03%
==========================================
Files 134 134
Lines 9960 9966 +6
==========================================
+ Hits 7263 7271 +8
+ Misses 2279 2278 -1
+ Partials 418 417 -1
Continue to review full report at Codecov.
|
CLI options have the highest priority, so the cli options which have a default value will always override options of other mechanisms. To fix it, we only set default value after consolidated config process. Close #1010
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
We should probably create an issue, with other config options which probably need this treatment, @na--
p.s. Sorry for the long delay :(
@mstoykov I did look for other flags, but sounds like only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks, and sorry for the huge delay, we had to deal with some issues surrounding k6 v0.25.0 😞
Looking at the options code, I don't immediately see any other options that would have the same issue, but I haven't actually tested them one by one... So I'd say we should merge this and deal with any others in separate PRs. @mstoykov, I think we should merge this and include it in v0.25.1, right?
This seems like low risk commit to me so I okay with that |
CLI options have the highest priority, so the cli options which have a
default value will always override options of other mechanisms.
To fix it, we only set default value after consolidated config process.
Close #1010