Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dependencies, support for other charsets, added more logging … #13

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bmxmiko
Copy link

@bmxmiko bmxmiko commented Sep 11, 2022

…methods to console object

Description

Updated dependencies.
Support for other charsets like ISO-8859-1
Added more logging method to console object like log, trace, error.

Context

Fix first impressions. When I tried this app, I tried to open google.com and got error (Google uses ISO-8859-1)
Testing JS, first thing i types was console.log and got error as well. I believe a lot of people use above steps jus to check this app.

Checklist

  • I opened a draft PR or added the [WIP] level if my PR is not ready for review.
  • I have reviewed the code by myself.
  • I have assigned an appropriate reviewer for the PR.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have added tests enough to show how your code behaves and that your code works as expected.

Additional Notes

TODO: Describe any other information you'd like to mention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant