From 71bfcc7e7cc423ca8ef05e48364592afa640f7c6 Mon Sep 17 00:00:00 2001
From: Will Shanks <wshaos@posteo.net>
Date: Sat, 13 Jul 2024 12:35:33 -0400
Subject: [PATCH] Add CI run that tests the package without numpy installed

Given that it is common to work with Uncertainties and numpy, it is easy
to forget to check that a hard dependency on numpy has been introduced.
Here an extra run is added to the CI configuration to run the tests
without installing numpy.
---
 .github/workflows/python-package.yml | 25 ++++++++++++++++++++++++-
 tests/test_uncertainties.py          |  2 +-
 2 files changed, 25 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/python-package.yml b/.github/workflows/python-package.yml
index 09fd1821..86e363d9 100644
--- a/.github/workflows/python-package.yml
+++ b/.github/workflows/python-package.yml
@@ -38,6 +38,29 @@ jobs:
       with:
         token: ${{ secrets.CODECOV_TOKEN }}
         slug: lmfit/uncertainties
+  test_without_numpy:
+    name: Test without numpy
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v4
+    - name: Set up Python
+      uses: actions/setup-python@v5
+      with:
+        python-version: ${{ matrix.python-version }}
+    - name: Install dependencies
+      run: |
+        python -m pip install --upgrade pip
+        python -m pip install .[test]
+    - name: Test source code and docs
+      run:
+        cd tests;
+        python -m pytest --ignore=test_unumpy.py --ignore=test_ulinalg.py -k "not test_monte_carlo_comparison"
+          --cov=uncertainties --cov=. --cov-report=xml --cov-report=term
+    - name: Upload coverage reports to Codecov
+      uses: codecov/codecov-action@v4.0.1
+      with:
+        token: ${{ secrets.CODECOV_TOKEN }}
+        slug: lmfit/uncertainties
   results:
     # This step aggregates the results from all the tests and allows us to
     # require only this single job to pass for a PR to be merged rather than
@@ -46,7 +69,7 @@ jobs:
     if: ${{ always() }}
     runs-on: ubuntu-latest
     name: Final Results
-    needs: [build]
+    needs: [build,test_without_numpy]
     steps:
       - run: exit 1
         if: >-
diff --git a/tests/test_uncertainties.py b/tests/test_uncertainties.py
index 54852ae8..4738371e 100644
--- a/tests/test_uncertainties.py
+++ b/tests/test_uncertainties.py
@@ -15,7 +15,6 @@
     numbers_close,
     ufloats_close,
     compare_derivatives,
-    uarrays_close,
 )
 
 
@@ -1711,6 +1710,7 @@ def test_custom_pretty_print_and_latex():
 # The tests below require NumPy, which is an optional package:
 try:
     import numpy
+    from helpers import uarrays_close
 except ImportError:
     pass
 else: