fix(codemods): Codemods create extra parentheses #1727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
pavelklibani
force-pushed
the
fix/ds-1529-codemod-paretheses
branch
from
99e5996 to
77f43f0
Compare
crishpeen
force-pushed
the
integration/BC-v3-design-tokens
branch
from
fa33a68 to
bab5113
Compare
crishpeen
force-pushed
the
fix/ds-1529-codemod-paretheses
branch
from
77f43f0 to
3dfd2a0
Compare
literat
reviewed
Nov 5, 2024
literat
reviewed
Nov 5, 2024
...es/codemods/src/transforms/v3/web-react/__testfixtures__/button-isSquare-prop-name.input.tsx
Show resolved
Hide resolved
literat
reviewed
Nov 5, 2024
crishpeen
force-pushed
the
integration/BC-v3-design-tokens
branch
from
c1a59e5 to
cf52609
Compare
crishpeen
force-pushed
the
fix/ds-1529-codemod-paretheses
branch
from
3dfd2a0 to
76e0978
Compare
crishpeen
force-pushed
the
integration/BC-v3-design-tokens
branch
from
3a41dee to
271af54
Compare
crishpeen
force-pushed
the
fix/ds-1529-codemod-paretheses
branch
from
c51d9a0 to
1033949
Compare
literat
force-pushed
the
integration/BC-v3-design-tokens
branch
from
e6acc7f to
45fe689
Compare
pavelklibani
changed the base branch from
integration/BC-v3-design-tokens
to
main
pavelklibani
force-pushed
the
fix/ds-1529-codemod-paretheses
branch
2 times, most recently
from
3c68cd9 to
eeeb900
Compare
- codemods were adding extra parentheses to the code when there was return statement
pavelklibani
force-pushed
the
fix/ds-1529-codemod-paretheses
branch
from
eeeb900 to
ed08f81
Compare
pavelklibani
requested review from
adamkudrna,
crishpeen,
curdaj and
a team
as code owners
literat
approved these changes
Nov 29, 2024
curdaj
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimges codemods are adding extra parentheses around component and it should not.
There is a bug in
recastlibrary used byjscodeshift(codemod library) casing this behaviour.Additional context
It will happen when there is
returnstatement in the component.More info can be found here:
facebook/jscodeshift#534
benjamn/recast#1406
Issue reference
Codemods are adding extra parentheses