Skip to content

Commit

Permalink
BREAKING CHANGE(web-twig): Remove Twig boolprop filter and its exte…
Browse files Browse the repository at this point in the history
…nsion #DS-798

 ## Migration Guide

You should rely on the default Twig types to manage your boolean props.
Eliminate the use of the `boolprop` filter and ensure that your props
are correctly set where your components are used.

Please refer back to this guide or reach out to our team
if you encounter any issues during migration.
  • Loading branch information
crishpeen authored and literat committed Jul 21, 2023
1 parent 981195b commit f71a8b0
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 94 deletions.
4 changes: 0 additions & 4 deletions packages/web-twig/src/Resources/config/services.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,6 @@ services:
tags:
- { name: twig.extension }

Lmc\SpiritWebTwigBundle\Twig\BoolpropExtension:
tags:
- { name: twig.extension }

Lmc\TwigXBundle\Compiler\ComponentLexer:
arguments:
- '@twig'
Expand Down
28 changes: 0 additions & 28 deletions packages/web-twig/src/Twig/BoolpropExtension.php

This file was deleted.

4 changes: 0 additions & 4 deletions packages/web-twig/tests/Helper/TwigHelper.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

use Lmc\SpiritWebTwigBundle\DependencyInjection\CompilerPass\OverrideServiceCompilerPass;
use Lmc\SpiritWebTwigBundle\DependencyInjection\SpiritWebTwigExtension;
use Lmc\SpiritWebTwigBundle\Twig\BoolpropExtension;
use Lmc\SpiritWebTwigBundle\Twig\PropsExtension;
use Lmc\SpiritWebTwigBundle\Twig\SvgExtension;
use Lmc\TwigXBundle\Compiler\ComponentLexer;
Expand Down Expand Up @@ -46,9 +45,6 @@ public static function setup(
$propsExtension = new PropsExtension();
$twig->addExtension($propsExtension);

$boolpropExtension = new BoolpropExtension();
$twig->addExtension($boolpropExtension);

$svgExtension = new SvgExtension(new Logger());
$twig->addExtension($svgExtension);

Expand Down
58 changes: 0 additions & 58 deletions packages/web-twig/tests/Twig/BoolpropExtensionTest.php

This file was deleted.

0 comments on commit f71a8b0

Please sign in to comment.