From 462a24545c6eafde7299d3bb96badd30fcdb6919 Mon Sep 17 00:00:00 2001 From: Pavel Klibani Date: Wed, 19 Jul 2023 13:14:46 +0200 Subject: [PATCH] BREAKING CHANGE(web): Remove modal body padding feature class #DS-863 ## Migration guide Remove feature class `.spirit-v1-modal-body-padding`, if used. No other actions are required. Please refer back to this guide or reach out to our team if you encounter any issues during migration. --- .../web/src/scss/components/Modal/README.md | 13 ---- .../src/scss/components/Modal/_ModalBody.scss | 6 +- .../web/src/scss/components/Modal/index.html | 75 ------------------- 3 files changed, 1 insertion(+), 93 deletions(-) diff --git a/packages/web/src/scss/components/Modal/README.md b/packages/web/src/scss/components/Modal/README.md index 7d7f69e399..93e96346ad 100644 --- a/packages/web/src/scss/components/Modal/README.md +++ b/packages/web/src/scss/components/Modal/README.md @@ -140,19 +140,6 @@ ModalBody holds the actual content of the Modal. ``` -### Feature Flag to Enable Extra Padding - -⚠️ This feature flag is only temporary and will be removed in version 1. The extra vertical padding will be made default. - -To enable vertical padding on ModalBody, add the feature class `spirit-v1-modal-body-padding` to a parent element. -The preferred one is the `body` element because this way it will affect all Modal components everywhere. - -```html - - - -``` - ## ModalFooter ModalFooter is the place for actions represented by the Button component. diff --git a/packages/web/src/scss/components/Modal/_ModalBody.scss b/packages/web/src/scss/components/Modal/_ModalBody.scss index 827640d47e..f05446dd5f 100644 --- a/packages/web/src/scss/components/Modal/_ModalBody.scss +++ b/packages/web/src/scss/components/Modal/_ModalBody.scss @@ -9,6 +9,7 @@ flex: 1 1 auto; min-height: map.get(theme.$typography, mobile, font-size) * map.get(theme.$typography, mobile, line-height); // 1. padding-inline: theme.$common-padding-x; + padding-block: theme.$body-padding-y; overflow-x: hidden; overflow-y: auto; overscroll-behavior: contain; @@ -17,8 +18,3 @@ padding-inline: theme.$common-padding-x-tablet; } } - -// @deprecated Will be removed in the next major version. -.spirit-v1-modal-body-padding .ModalBody { - padding-block: theme.$body-padding-y; -} diff --git a/packages/web/src/scss/components/Modal/index.html b/packages/web/src/scss/components/Modal/index.html index a1d6927d26..2680a93e64 100644 --- a/packages/web/src/scss/components/Modal/index.html +++ b/packages/web/src/scss/components/Modal/index.html @@ -530,81 +530,6 @@

-
-

V1 Feature — Vertical Padding on Body

- - - - - - - -
- - -
-

Modal Title

- -
- - - -
- -

- Lorem ipsum dolor sit amet, consectetur adipisicing elit. Aliquam at excepturi laudantium magnam mollitia - perferendis reprehenderit, voluptate. Cum delectus dicta ducimus eligendi excepturi natus perferendis - provident unde. Eveniet, iste, molestiae? -

- -
- - - -
-
- -
-
- - -
- - - - - -

Stacking Modals