Torch: Fold RuntimeAssertOp when condition is true #2198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 tasks
mgehre-amd
force-pushed
the
matthias.fold_runtime_assert
branch
from
d7b0e46
to
99450b6
Compare
qingyunqu
reviewed
Jun 6, 2023
ramiro050
approved these changes
Jun 7, 2023
There was a problem hiding this comment.
Can you also add a lit test in: https://github.com/llvm/torch-mlir/blob/main/test/Dialect/Torch/canonicalize.mlir
Other than that, LGTM
mgehre-amd
force-pushed
the
matthias.fold_runtime_assert
branch
from
9f722e9
to
8938962
Compare
mgehre-amd
force-pushed
the
matthias.fold_runtime_assert
branch
from
8938962
to
d23bdd2
Compare
Done! |
gpetters94
pushed a commit
to gpetters94/mlir-npcomp
that referenced
this pull request
Jul 7, 2023
gpetters94
pushed a commit
to gpetters94/mlir-npcomp
that referenced
this pull request
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The runtime.assert op gets introduced by some decompositions.
In the cases we saw, the condition got simplified to
true, so we can remove the assert again.This makes two tests pass with TOSA.