-
Notifications
You must be signed in to change notification settings - Fork 12.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AArch64][GlobalISel] Combine G_EXTRACT_VECTOR_ELT and G_BUILD_VECTOR sequences into G_SHUFFLE_VECTOR #110545
Open
ValentijnvdBeek
wants to merge
11
commits into
llvm:main
Choose a base branch
from
ValentijnvdBeek:valentijnbeek-combine-extract-build
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[AArch64][GlobalISel] Combine G_EXTRACT_VECTOR_ELT and G_BUILD_VECTOR sequences into G_SHUFFLE_VECTOR #110545
ValentijnvdBeek
wants to merge
11
commits into
llvm:main
from
ValentijnvdBeek:valentijnbeek-combine-extract-build
Commits on Sep 27, 2024
-
[GlobalISel] Remove inaccurate input vector restriction
In the buildShuffleVector method, there is a restriction that the input vectors must be larger than the mask. However, this is not the definition of a ShuffleVector instruction that is used inside of our test suite. For example: shuffle_concat_1 in combine_shuffle_vector.mir: 4xs8 -> 16xs8 v3s8_crash in legalize_insert_vector_elt: 3xs8 -> 12xs8 shuffle_vector_to_concat_vector_45670123 in prelegalizercombiner-shuffle-vector: 4xs32 -> 12xs32
Configuration menu - View commit details
-
Copy full SHA for 76d4bda - Browse repository at this point
Copy the full SHA 76d4bdaView commit details
Commits on Oct 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0d5d582 - Browse repository at this point
Copy the full SHA 0d5d582View commit details
Commits on Oct 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4f2fdcd - Browse repository at this point
Copy the full SHA 4f2fdcdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 633b8fc - Browse repository at this point
Copy the full SHA 633b8fcView commit details -
[AArch64][GlobalISel] Combine G_EXTRACT_VECTOR_ELT and G_BUILD_VECTOR…
… sequences into G_SHUFFLE_VECTOR This combine tries to find all the build vectors whose source elements all originate from a G_EXTRACT_VECTOR_ELT from one or two donor vectors. One example where this may happen is for AI chips where there are a lot of matrix multiplications. Typically there vectors are disected and then rearranged into the right transformation. E.g. %donor1(<2 x s32>) = COPY $d0 %donor2(<2 x s32>) = COPY $d1 %ext1 = G_EXTRACT_VECTOR_ELT %donor1, 0 %ext2 = G_EXTRACT_VECTOR_ELT %donor1, 1 %ext3 = G_EXTRACT_VECTOR_ELT %donor2, 0 %ext4 = G_EXTRACT_VECTOR_ELT %donor2, 1 %vector = G_BUILD_VECTOR %ext1, %ext2, %ext3, %ext4 ==> replace with: %vector = G_SHUFFLE_VECTOR %donor1, %donor2, shufflemask(0, 1, 2, 3)
Configuration menu - View commit details
-
Copy full SHA for f464323 - Browse repository at this point
Copy the full SHA f464323View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6cb6d38 - Browse repository at this point
Copy the full SHA 6cb6d38View commit details -
Configuration menu - View commit details
-
Copy full SHA for f93503c - Browse repository at this point
Copy the full SHA f93503cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 35500c6 - Browse repository at this point
Copy the full SHA 35500c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ef5773 - Browse repository at this point
Copy the full SHA 1ef5773View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3bdebfa - Browse repository at this point
Copy the full SHA 3bdebfaView commit details -
Configuration menu - View commit details
-
Copy full SHA for baa7cd8 - Browse repository at this point
Copy the full SHA baa7cd8View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.