Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AArch64][Windows] Fix stack probing to match recent non-Windows improvements #73975

Open
efriedma-quic opened this issue Nov 30, 2023 · 1 comment

Comments

@efriedma-quic
Copy link
Collaborator

The recent implementation of stack probing for stack-clash (#66525 #66524 etc.)has exposed a few cases where we don't properly probe the stack according to the Windows rules. Specifically:

  • For large call frames (calling a function with many arguments, where the caller also has dynamic allocation)
  • For SVE locals/spills.

Also, we might want to consider leveraging the new inline probing sequences in some cases instead of calling __chkstk.

CC @mstorsjo

@llvmbot
Copy link
Member

llvmbot commented Nov 30, 2023

@llvm/issue-subscribers-backend-aarch64

Author: Eli Friedman (efriedma-quic)

The recent implementation of stack probing for stack-clash (#66525 #66524 etc.)has exposed a few cases where we don't properly probe the stack according to the Windows rules. Specifically:
  • For large call frames (calling a function with many arguments, where the caller also has dynamic allocation)
  • For SVE locals/spills.

Also, we might want to consider leveraging the new inline probing sequences in some cases instead of calling __chkstk.

CC @mstorsjo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants