Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport fix for clangd#1743 to 17.x branch #72621

Closed
HighCommander4 opened this issue Nov 17, 2023 · 4 comments · Fixed by llvm/llvm-project-release-prs#779
Closed

Backport fix for clangd#1743 to 17.x branch #72621

HighCommander4 opened this issue Nov 17, 2023 · 4 comments · Fixed by llvm/llvm-project-release-prs#779
Labels
clangd release:backport release:merged
Milestone
LLVM 17.0.X Release

Comments

@HighCommander4
Copy link
Collaborator

I would like to propose backporting the fix for clangd/clangd#1743 to the 17.x branch.

This fix is low risk (it's just adding a null pointer check), and it fixes a clangd crash.
@HighCommander4 HighCommander4 added this to the LLVM 17.0.X Release milestone Nov 17, 2023
@github-project-automation github-project-automation bot moved this to Needs Triage in LLVM Release Status Nov 17, 2023
@HighCommander4
Copy link
Collaborator Author

/cherry-pick 1994e11

@HighCommander4 HighCommander4 mentioned this issue Nov 17, 2023
Closed
@llvmbot
Copy link
Member

llvmbot commented Nov 17, 2023

/branch llvm/llvm-project-release-prs/issue72621

@llvmbot llvmbot mentioned this issue Nov 17, 2023
Merged
@llvmbot
Copy link
Member

llvmbot commented Nov 17, 2023

/pull-request llvm/llvm-project-release-prs#779

@llvmbot
Copy link
Member

llvmbot commented Nov 17, 2023

@llvm/issue-subscribers-clangd

Author: Nathan Ridge (HighCommander4)

I would like to propose backporting the fix for https://github.com/clangd/clangd/issues/1743 to the 17.x branch.

This fix is low risk (it's just adding a null pointer check), and it fixes a clangd crash.

@tru tru moved this from Needs Triage to Needs Review in LLVM Release Status Nov 20, 2023
@tru tru moved this from Needs Review to Done in LLVM Release Status Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clangd release:backport release:merged
Projects
LLVM Release Status
Status: Done
Milestone
LLVM 17.0.X Release
Development

Successfully merging a pull request may close this issue.

PR for llvm/llvm-project#72621 llvm/llvm-project-release-prs
3 participants
@HighCommander4 @EugeneZelenko @llvmbot