Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LLVM 17][libc++] Cherry-pick the fix for std::expected UB related to the has-value flag #70708

Closed
ldionne opened this issue Oct 30, 2023 · 3 comments · Fixed by llvm/llvm-project-release-prs#762
Closed

[LLVM 17][libc++] Cherry-pick the fix for std::expected UB related to the has-value flag #70708

ldionne opened this issue Oct 30, 2023 · 3 comments · Fixed by llvm/llvm-project-release-prs#762
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. release:backport release:merged
Milestone
LLVM 17.0.X Release

Comments

@ldionne
Copy link
Member

ldionne commented Oct 30, 2023

We should cherry-pick this PR (#68733) which fixed this issue (#68552). Doing this is not an ABI break (unlike the follow-up #69673 which is an ABI break, and we're still undecided about this one).

I think it makes sense to make the present fix regardless of what we end up doing for the tail-padding issue (the ABI breaking one).
@ldionne ldionne added this to the LLVM 17.0.X Release milestone Oct 30, 2023
@github-project-automation github-project-automation bot moved this to Needs Triage in LLVM Release Status Oct 30, 2023
@ldionne ldionne added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Oct 30, 2023
@ldionne
Copy link
Member Author

ldionne commented Oct 30, 2023

/branch ldionne/review/cherry-pick-has-value-fix-LLVM-17

@DanAlbert DanAlbert mentioned this issue Oct 30, 2023
Closed
@nikic
Copy link
Contributor

nikic commented Oct 31, 2023

/branch ldionne/llvm-project/review/cherry-pick-has-value-fix-LLVM-17

@nikic nikic moved this from Needs Triage to Needs Pull Request in LLVM Release Status Oct 31, 2023
@llvmbot llvmbot mentioned this issue Oct 31, 2023
Merged
@llvmbot
Copy link
Member

llvmbot commented Oct 31, 2023

/pull-request llvm/llvm-project-release-prs#762

@nikic nikic moved this from Needs Pull Request to Needs Review in LLVM Release Status Oct 31, 2023
@tru tru moved this from Needs Review to Done in LLVM Release Status Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. release:backport release:merged
Projects
LLVM Release Status
Status: Done
Milestone
LLVM 17.0.X Release
Development

Successfully merging a pull request may close this issue.

PR for llvm/llvm-project#70708 llvm/llvm-project-release-prs
4 participants
@nikic @ldionne @EugeneZelenko @llvmbot