Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge ra7137b238a07 into the 12.0 branch #49975

Closed
tstellar opened this issue Jun 9, 2021 · 5 comments
Closed

Merge ra7137b238a07 into the 12.0 branch #49975

tstellar opened this issue Jun 9, 2021 · 5 comments
Assignees
Labels
bugzilla Issues migrated from bugzilla

Comments

@tstellar
Copy link
Collaborator

tstellar commented Jun 9, 2021

Bugzilla Link 50631
Resolution FIXED
Resolved on Jun 10, 2021 16:09
Version 12.0
OS All
Blocks #48661
CC @yonghong-song
Fixed by commit(s) a7137b2 319a27b

Extended Description

Is it OK to merge the following revision(s) to the 12.0 branch?

@tstellar
Copy link
Collaborator Author

tstellar commented Jun 9, 2021

assigned to @4ast

@tstellar
Copy link
Collaborator Author

tstellar commented Jun 9, 2021

@tstellar
Copy link
Collaborator Author

tstellar commented Jun 9, 2021

Alexei,

What do you think about backporting this? It fixes some of the kernel bpf selftests with LLVM12 according to selftests/bpf/README.rst.

https://reviews.llvm.org/rGa7137b238a07

@4ast
Copy link
Member

4ast commented Jun 10, 2021

I don't see why backporting BTF for FLOAT shouldn't be done. The kernel has float vars, so it's more valid to emit them into BTF instead of faking them as INTs. libbpf supports FLOATs too. Just make sure to run libbpf that knows about it. There could be weird combinations of older libbpf and older kernel that don't know about FLOAT, but it's better to have a clear err on unrecognized FLOAT.

@tstellar
Copy link
Collaborator Author

Merged: 319a27b

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 11, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Issues migrated from bugzilla
Projects
None yet
Development

No branches or pull requests

2 participants