[FIRRTL] Add verifier of single MarkDUTAnnotation #7633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a CircuitOp verifier that guarantees that there is zero or one modules annotated with a `MarkDUTAnnotation`. This is important as many passes assume that this is the case. Moving this check into a verifier means that logic checking this behavior in each pass can be removed. I am slightly concerned of the performance cost of doing this as examining the annotations is non-trivial and this will cause that examination to now happen more often. Signed-off-by: Schuyler Eldridge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a CircuitOp verifier that guarantees that there is zero or one modules annotated with a
MarkDUTAnnotation. This is important as many passes assume that this is the case. Moving this check into a verifier means that logic checking this behavior in each pass can be removed. I am slightly concerned of the performance cost of doing this as examining the annotations is non-trivial and this will cause that examination to now happen more often.