Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIRRTL][GrandCentral] Remove legacy Augmented types. #7592

Merged

Conversation

dtzSiFive
Copy link
Contributor

Remove String, Boolean, Integer, Double, Literal, Deleted.

Instead of ignoring these, they will now be errors.

This reduces supported types to: Ground, Vector, Bundle.

Remove String, Boolean, Integer, Double, Literal, Deleted.

Instead of ignoring these, they will now be errors.

This reduces supported types to: Ground, Vector, Bundle.
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Amazingly I don't think this was ever load bearing. I can look at changes internally to make this impossible to emit.

@dtzSiFive dtzSiFive merged commit 6176d13 into llvm:main Sep 10, 2024
4 checks passed
@dtzSiFive dtzSiFive deleted the feature/gcv-remove-legacy-augmented-types branch September 10, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants