[MooreToCore] Fix variable op lowering of aggregate types #7481
Conversation
| // TODO: Unsupport x/z, so the initial value is 0. | ||
| if (!init && cast<RefType>(op.getResult().getType()).getDomain() == | ||
| Domain::FourValued) | ||
| return failure(); |
There was a problem hiding this comment.
I'm wondering whether we should remove this check and generally lower everything to an i1 for now by mapping X and Z bits to 0. Verilator does a similar thing. Later, once we have proper support for four-valued types in HW/Comb/Seq, we could come back and adjust the lowering again.
There was a problem hiding this comment.
I support choosing x / z pessimistic strategy. Once we support multi-valued types in the core IR. A new option could be added to control whether to enable the optimistic strategy - spread x / z value and preserve its value to calculate.
There was a problem hiding this comment.
Adding a pass option to let the user decide whether x/z should be converted to 0 sounds like a reasonable approach to me. I'll leave it for a follow-up PR.
No description provided.