[circt-lec] Accept two MLIR inputs #7450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uenoku
force-pushed
the
dev/hidetou/circt-lec-two-files
branch
4 times, most recently
from
1f8494e
to
4e9f734
Compare
Practically it is very useful to verify equivalence between modules in two different MLIR files. This commit changes `inputFilename` to a list and merge modules by renaming symbols.
uenoku
force-pushed
the
dev/hidetou/circt-lec-two-files
branch
from
4e9f734
to
ab8334b
Compare
TaoBi22
approved these changes
Aug 7, 2024
|
Very nice! Thanks for adding this 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Practically it is very useful to verify equivalence between modules in two different MLIR files. This commit changes
inputFilenameto a list and implements a very simple module merge that moves operations in the second module to the first by resolving the symbol.