Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIRRTL] Tweak printing of layers to avoid extra space. #7449

Merged
merged 1 commit into from
Aug 6, 2024
Merged

[FIRRTL] Tweak printing of layers to avoid extra space. #7449

merged 1 commit into from
Aug 6, 2024

Conversation

dtzSiFive
Copy link
Contributor

@dtzSiFive dtzSiFive commented Aug 6, 2024 •
edited
Loading

Before:

firrtl.layer @A  inline

After:

firrtl.layer @A inline

@dtzSiFive
[FIRRTL] Tweak printing of layers to avoid extra space.
d135c6a 
Before:

firrtl.layer @A  inline

After:

firrtl.layer @A inline
@dtzSiFive dtzSiFive requested a review from rwy7 August 6, 2024 15:56
seldridge
seldridge approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Is it really that easy?

@dtzSiFive dtzSiFive merged commit 1645d71 into llvm:main Aug 6, 2024
4 checks passed
@dtzSiFive dtzSiFive deleted the fix/layer-space-before-convention branch August 6, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwy7 rwy7 rwy7 approved these changes

@seldridge seldridge seldridge approved these changes

@darthscsi darthscsi Awaiting requested review from darthscsi darthscsi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dtzSiFive @seldridge @rwy7