[FIRRTL] Verify main module is a module, and is public. #7439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtzSiFive
force-pushed
the
feature/circuit-verify-main-module-is-public-module
branch
from
e45294c
to
7b6c7c8
Compare
Add tests for new errors and existing error (changed). Op errors should remember to make sense when read prefixed with "mydialect.opname op ".
dtzSiFive
force-pushed
the
feature/circuit-verify-main-module-is-public-module
branch
from
7b6c7c8
to
328fd60
Compare
fabianschuiki
approved these changes
Aug 6, 2024
dtzSiFive
deleted the
feature/circuit-verify-main-module-is-public-module
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for new errors and existing error (changed).
Op errors should remember to make sense when read prefixed with "mydialect.opname op ".