Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIRRTL] Verify RWProbeOp target has layer requirements. #7372

Merged
merged 2 commits into from
Aug 6, 2024
Merged

[FIRRTL] Verify RWProbeOp target has layer requirements. #7372

merged 2 commits into from
Aug 6, 2024

Conversation

dtzSiFive
Copy link
Contributor

RWProbe conservatively means a write to the target, so check that the target is indeed writeable from where the rwprobe is.

@dtzSiFive
[FIRRTL] Verify RWProbeOp target has layer requirements.
15586de 
RWProbe conservatively means a write to the target, so check
that the target is indeed writeable from where the rwprobe is.
@dtzSiFive dtzSiFive requested a review from rwy7 July 22, 2024 18:51
@dtzSiFive dtzSiFive mentioned this pull request Jul 26, 2024
Closed
seldridge
seldridge approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test/Dialect/FIRRTL/errors.mlir Show resolved Hide resolved
@dtzSiFive dtzSiFive merged commit 4415b9c into llvm:main Aug 6, 2024
4 checks passed
@dtzSiFive dtzSiFive deleted the feature/rwprobe-layer-requirements branch August 6, 2024 16:03
@dtzSiFive
Copy link
Contributor Author

Thanks!

@dtzSiFive dtzSiFive mentioned this pull request Aug 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seldridge seldridge seldridge approved these changes

@rwy7 rwy7 Awaiting requested review from rwy7

@darthscsi darthscsi Awaiting requested review from darthscsi darthscsi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtzSiFive @seldridge