Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump LLVM to 1e828f838cc0f15074f3dbbb04929c06ef0c9729. #6784

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

mikeurbach
Copy link
Contributor

This picks up a bugfix in DialectConversion:
llvm/llvm-project@9606655

@mikeurbach
Copy link
Contributor Author

Opening this PR to share the status with the latest LLVM.

@seldridge pointed out the failure in nightly CI: https://github.com/llvm/circt/actions/runs/8155859443/job/22292261940#step:6:4600

That seems to be related to an upstream bug in DialectConversion: llvm/llvm-project@9606655

However, bumping past that, we are now hitting asserts in DialectConversion, which appear to be added in: llvm/llvm-project@6008cd4

We are probably use DialectConversion in a way that is illegal, and now the infra is being stricter. The commit message above explains a concrete example, and how to rewrite it. We probably need to track down the failures and do the same.

@mikeurbach
Copy link
Contributor Author

Ibis folks--please see the linked issue. I tried to figure out how to avoid the new assertions in the Ibis transforms, but I'm not familiar enough with these passes to know the right fix. I'm proposing to XFAIL these tests so we can make progress with getting this LLVM bump in and fix the use-after-free we currently enjoy on main.

@mikeurbach
Copy link
Contributor Author

No longer XFAILing the Ibis tests. I'll merge this once CI completes.

@mikeurbach mikeurbach merged commit e49188b into main Mar 7, 2024
4 checks passed
@mikeurbach mikeurbach deleted the mikeurbach/bump-llvm branch March 7, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant