[Seq] Allow presets for more types on firreg #6781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nandor
force-pushed
the
dev/nandor/seq-preset
branch
2 times, most recently
from
3ad639c
to
c5392a5
Compare
seldridge
reviewed
Mar 4, 2024
| if (hw::type_isa<seq::ClockType>(ty)) { | ||
| width = 1; | ||
| } else { | ||
| int64_t maybeWidth = hw::getBitWidth(ty); |
There was a problem hiding this comment.
Does this work for 64-bit unsigned types?
There was a problem hiding this comment.
The issue I was concerned about is that this was casting an unsigned type returned by hw::getBitWidth to a signed type. However, hw::getBitWidth returns an int64_t so there is no problem. If this was an issue, then this would have to be an absolutely enormous constant...
nandor
force-pushed
the
dev/nandor/seq-preset
branch
from
c5392a5
to
6c6e5be
Compare
seldridge
approved these changes
Mar 5, 2024
| if (hw::type_isa<seq::ClockType>(ty)) { | ||
| width = 1; | ||
| } else { | ||
| int64_t maybeWidth = hw::getBitWidth(ty); |
There was a problem hiding this comment.
The issue I was concerned about is that this was casting an unsigned type returned by hw::getBitWidth to a signed type. However, hw::getBitWidth returns an int64_t so there is no problem. If this was an issue, then this would have to be an absolutely enormous constant...
nandor
force-pushed
the
dev/nandor/seq-preset
branch
from
6c6e5be
to
5165fb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.