Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve 'token list ended unexpectedly` error message #6

Open
lloyddewit opened this issue Feb 10, 2022 · 3 comments
Open

Improve 'token list ended unexpectedly` error message #6

lloyddewit opened this issue Feb 10, 2022 · 3 comments

Comments

@lloyddewit
Copy link
Owner

In R-Instat issue #7199 @Patowhiz states:

For detected invalid R like in this case, should it have given a hint about the each parameter value missing? As a developer using the library, I would expect the class to give me a hint about the invalid R and possibly point out the exact invalid token I guess that may not have been a priority to implement, if so the undefined behavior seems fine, the comment clearly explained it.

Error thrown Rscript_error

@Patowhiz
Copy link

@lloyddewit thanks. Would you like me to have a look at it? I always find it interesting when I look at how you design and write your code.
I also acknowledge it may be more time efficient if you look at it.

@lloyddewit
Copy link
Owner Author

@Patowhiz thanks, though there's not much interesting in this part of the code and enhancing the error message is straightforward.
'RScript' is currently only on my personal github repo, it's not set up yet for general maintenance.
In December, I also converted RScript to Python (here) and it may be better to do future development on the Python version. It depends if/how R-Instat and OpenCDMS use the library.
In summary, I'm happy just to collect known issues here. It's not a priority to fix this issue now.

@Patowhiz
Copy link

@lloyddewit sounds good. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants