Add AudioReactiveBlendshapes.cs and related files #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A small utility script based off `AudioReactiveLight.cs` for blendshapes
pema99
reviewed
Sep 7, 2024
| if (audioLink.AudioDataIsAvailable()) | ||
| { | ||
| // Convert to grayscale | ||
| float amplitude = Vector3.Dot(audioLink.GetDataAtPixel(delay, band), new Vector3(0.299f, 0.587f, 0.114f)) * 100f; |
There was a problem hiding this comment.
Hmm this grayscale conversion looks sus to me. In the 4band section, each channel means a different thing (they are different levels of filtering, not chroma values). You should probably just select 1 single channel, and maybe put the channel select on a dropdown
There was a problem hiding this comment.
Set it to access the pixel's red value for now,
I like the idea of having an option to select which channel to read from a pixel, though that may be better as a enum in a different file
|
Thanks looks nice - check my comment |
pema99
reviewed
Sep 7, 2024
|
|
||
| public class AudioReactiveBlendshapes : UdonSharpBehaviour | ||
| #else | ||
| public class AudioReactiveBlendshapes : MonoBehaviour |
There was a problem hiding this comment.
Use [RequireComponent(typeof(SkinnedMeshRenderer))] ?
There was a problem hiding this comment.
SkinnedMeshRenderer is now required
Require SkinnedMeshRenderer, remove unused _dataIndex, skip Vector.Dot and instead access pixel's red channel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small utility script based off
AudioReactiveLight.csfor blendshapes, allowing a user to quickly drive blendshapes by specifying their index in an array.