Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: DATABASE_URL from env doesn't work in new 6.5.x #356

Closed
remicollet opened this issue Oct 24, 2022 · 4 comments
Closed

regression: DATABASE_URL from env doesn't work in new 6.5.x #356

remicollet opened this issue Oct 24, 2022 · 4 comments
Assignees
Labels

Comments

@remicollet
Copy link
Contributor

remicollet commented Oct 24, 2022

Was working as expected in 6.4.x

$ phpcompatinfo diagnose
    ...
    >  [env(APP_DATABASE_URL)] sqlite:////usr/share/php-bartlett-PHP-CompatInfo/data/compatinfo-db.sqlite
    ....

First call is OK

$ export DATABASE_URL=sqlite:////tmp/compatinfo-db.sqlite
$ phpcompatinfo diagnose
    ...
    >  [env(APP_DATABASE_URL)] sqlite:////usr/share/php-bartlett-PHP-CompatInfo/data/compatinfo-db.sqlite
    ....

Second call is broken, DATABASE_URL env is ignored

Workaround

$ rm -rf ~/.cache/bartlett/
$ phpcompatinfo diagnose
    ...
    >  [env(APP_DATABASE_URL)] sqlite:////tmp/compatinfo-db.sqlite
    ....

So... cache issue.

So, this is a regression (tested with 6.5.1)

@llaville
Copy link
Owner

So... cache issue.

So, this is a regression (tested with 6.5.1)

I confirm it's a Symfony Container Compiled cache issue on my side. Good catch @remicollet !
I'll fix it tomorrow morning, because I've not enough time tonight.

@llaville llaville self-assigned this Oct 24, 2022
@llaville llaville added the bug label Oct 24, 2022
@llaville
Copy link
Owner

As it's related to database, the fix will be applied on PHP_CompatInfoDB.

FYI: as I've also some minor changes to do on CompatInfo, I'll also release a bugfix 6.5.2

@llaville
Copy link
Owner

@remicollet FYI :

I'll release both CompatInfoDB 4.6.1 and CompatInfo 6.5.2 in few hours unless we found another critical issue (but I don't think so ;-)

@llaville
Copy link
Owner

Versions CompatInfoDB 4.6.1 and CompatInfo 6.5.2 are now available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants