Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tap-react-browser #433

Merged
merged 1 commit into from
Apr 10, 2018
Merged

Add tap-react-browser #433

merged 1 commit into from
Apr 10, 2018

Conversation

mcnuttandrew
Copy link
Contributor

@mcnuttandrew mcnuttandrew commented Mar 28, 2018

First things first: Tape is a wonderful library, a++++, thank you for building it.

I would like to add my own tap reporter type thing to the list of reporters, tap-react-browser. As the name would suggest tap-react-browser is a component library for doing in browser testing with react+tape. It enables promisification of tests, but allows you to opt out. It plays nice with embedding components. I wasn't sure if it fit into tap reporters or other, so I went with other? But I welcome any feedback.

@ljharb
Copy link
Collaborator

ljharb commented Apr 10, 2018

hmm, adding fs: 'empty' shouldn't be needed because it's only required in the tape binary, which shouldn't be bundled up.

Thanks tho! "other" seems right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants