Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated jQuery Version #45

Closed
acahir opened this issue Feb 7, 2019 · 1 comment
Closed

Outdated jQuery Version #45

acahir opened this issue Feb 7, 2019 · 1 comment

Comments

@acahir
Copy link

acahir commented Feb 7, 2019

Why are you including such an old version of jQuery (1.12.4) in load-photoswipe.html? Current version is 3.3.1, so that's two major versions behind.

Considering PhotoSwipe doesn't require jQuery, could also just use vanilla js.

@liwenyip
Copy link
Owner

liwenyip commented Apr 22, 2019

Hi @acahir

There was probably a reason why I used that version of jQuery but I can't for the life of me remember what that reason was... and I don't want to mess with code that's not broken :-)

I used jQuery instead of vanilla js because I'm not a web developer (I currently work as a construction project manager) and jQuery was easier to grok at the time.

Migrating to vanilla js has been addressed in #27 and will probably happen eventually :-)

Regards,
Li-Wen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants