Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the conclusion type parameter of InferenceJustifier #2

Open
ykazakov opened this issue Jun 14, 2017 · 2 comments
Open

Remove the conclusion type parameter of InferenceJustifier #2

ykazakov opened this issue Jun 14, 2017 · 2 comments

Comments

@ykazakov
Copy link
Member

I do not see much use for the conclusion type parameter of InferenceJustifier.
Since there is no type parameter for type of inferences, a justifier should work with arbitrary inferences (over given conclusions). But any meaningful implementation of this interface would need to check the type of inferences (over concrete conclusions), and the conclusion type parameter will not be really used. Two possible fixes I see:

  • Either use a generic inference parameter <I extends Inference<?>>:
    J getJustification(I inference);
  • Or do not use any input parameter:
    J getJustification(Inference<?> inference);
@ykazakov
Copy link
Member Author

Alternatively on can use guava's Functor instead of Justifier

1 similar comment
@ykazakov
Copy link
Member Author

Alternatively on can use guava's Functor instead of Justifier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant