Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(participant): added stopOnUnpublish value to UnpublishTrackRequest #379

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(participant): added stopOnUnpublish value to UnpublishTrackRequest #379

wants to merge 2 commits into from

Conversation

s-hamdananwar
Copy link
Contributor

fixes #378

@s-hamdananwar s-hamdananwar requested a review from nbsp January 6, 2025 21:50
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 6, 2025

⚠️ No Changeset found

Latest commit: 4ae71b3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

lukasIO
lukasIO reviewed Jan 7, 2025
View reviewed changes
packages/livekit-rtc/src/participant.ts
@@ -373,6 +373,7 @@ export class LocalParticipant extends Participant {
const req = new UnpublishTrackRequest({
localParticipantHandle: this.ffi_handle.handle,
trackSid: trackSid,
stopOnUnpublish: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, we should also add this as an optional parameter in the public method that defaults to true

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lukasIO is there any time we would want it to be set as false, assuming the user might pass it in? we did the same in python sdk as well in this pr by hardcoding it to true without giving an option to the users. let me know what you think and i can update Python sdk as well accordingly if needed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the use case is for users to unpublish tracks without stopping them, which enables the re-use of tracks.

We do have this option in the browser SDK for that reason, I think it would make sense for node and python, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasIO lukasIO lukasIO left review comments

@nbsp nbsp Awaiting requested review from nbsp

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when calling unpublishTrack
2 participants
@s-hamdananwar @lukasIO