Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: 429 with exponential backoff fallback example #214

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iloveitaly
Copy link

This took me a bit to figure out. The wording on on_predicate made it sound like the predicate argument could be
either an exception or a value, but this is not the case.

@hhromic
Copy link

hhromic commented Jul 4, 2024

I was stuck for a while with this too, until I found this PR. Thanks!
For the record, I also got confused by the wording and also was struggling with on_predicate not processing exceptions.

The most important part for me from the content of this PR is to re-raise the exception inside the giveup handler to let it bubble-up to the next on_exception decorator and so on. Thanks for that tip!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants