Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.2.0 breaks our builds #16

Closed
incompl opened this issue Nov 7, 2016 · 3 comments
Closed

2.2.0 breaks our builds #16

incompl opened this issue Nov 7, 2016 · 3 comments

Comments

@incompl
Copy link

incompl commented Nov 7, 2016

Builds that do not use the new Microsoft Edge browser support (for example, one of them is Firefox-only) are breaking with this message:

Warning: Cannot find module 'edge-launcher/Win32/MicrosoftEdgeLauncher.exe' from '/home/travis/build/videojs/video.js/node_modules/karma-detect-browsers/browsers' Use --force to continue.

This broke the build for videojs and at least one of our other projects.
@LitixThomas
Copy link
Member

Please use fixed version 2.2.1.

@incompl
Copy link
Author

incompl commented Nov 7, 2016

It worked, thanks for the quick turnaround!

@forbesjo
Copy link

forbesjo commented Nov 7, 2016

See #17

@nickserv nickserv mentioned this issue Dec 11, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@incompl @LitixThomas @forbesjo