Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid running CI on self-hosted runner when possible #393

Closed
1 task
Kailai-Wang opened this issue Mar 7, 2022 · 3 comments · Fixed by #409
Closed
1 task

Avoid running CI on self-hosted runner when possible #393

Kailai-Wang opened this issue Mar 7, 2022 · 3 comments · Fixed by #409
Assignees
Labels
I2-medium should be completed within 10 working days

Comments

@Kailai-Wang
Copy link
Collaborator

Kailai-Wang commented Mar 7, 2022

Context

We run most of our CI jobs on a self-hosted machine, mostly because we want to push the docker image from there (where the docker credential is already configured)

This is causing a few problems:

  • the build is executed sequentially and very slow, especially when multiple PRs are pending
  • CI host is shared with other projects, which slows down the build further
  • They are not built in a standard env, so any env changes on the host could affect the output

image

Task

We should try to avoid using self-hosted runner when possible, especially for build & test.
We can leave as it is for other tasks where running on self-hosted runner is absolutely required (e.g. benchmarking, as we need to login to other remote hosts from the CI-host)

Acceptance criteria

  • remove all the self-hosted usage in build_and_run_test.yml

✔️ Please set appropriate labels and assignees if applicable.

@Kailai-Wang Kailai-Wang added I2-medium should be completed within 10 working days F2-tests/benchmarks/ci labels Mar 7, 2022
@Kailai-Wang
Copy link
Collaborator Author

Thanks to @geastwood , now DOCKERHUB* env is configured as GH secrets.

@Kailai-Wang
Copy link
Collaborator Author

building docker image takes 20 min on self-hosted runner while on github-runner it takes ~ 1hr.
I think we still need to keep docker-image building on self-hosted runner and do everything else on github runner

@Kailai-Wang
Copy link
Collaborator Author

Currently considering using docker/build-push-action to cache the docker image layers. Will make a few experimental commits and see how it performs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I2-medium should be completed within 10 working days
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant