Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Assertion 4: LIT Holder #1030

Closed
StamfordDigital opened this issue Sep 6, 2022 · 7 comments · Fixed by #1038
Closed

Build Assertion 4: LIT Holder #1030

StamfordDigital opened this issue Sep 6, 2022 · 7 comments · Fixed by #1038
Assignees

Comments

@StamfordDigital
Copy link

StamfordDigital commented Sep 6, 2022

Check whether any of the linked accounts holds a minimum amount (0.000001) of LIT NOW.

If TRUE, a VC should be generated and returned to the F/E. ?


Old description obsolate:

Build Assertion 4: LIT Holder which will generate a Verifiable Credential (VC) if the following validates:

  • Check the IDHub controller (user) holds LIT tokens
    • Important: A specific address must be provided and passed to the Parachain from the F/E using the params extrinsic param to verify this
  • If the ruleset validates then a VC should be generated and returned to the F/E.
@jingleizhang
Copy link
Contributor

Correct: this ruleset should test if “any of the linked accounts holds any LIT”. Not just the main address.

@Kailai-Wang
Copy link
Collaborator

This makes less sense though, as the main address has to hold some LIT to be able to send extrinsics at all. That's why I consider this rule a bit vague.

I suggest that we double-check it with Kayla or Rodrigo

@jingleizhang
Copy link
Contributor

The actual workflow is:

  • user calls the parachain extrinsic
  • parachain&TEE knows this user’s main address (Litentry parachain address)
  • because any active Litentry address needs to hold more than zero LIT tokens
  • TEE queries user’s any other linked and verified address(e.g, ETH address, BSC address)
  • and calculate ‘if they hold any LIT’, if true, TEE will generate a LIT Holder VC

@jingleizhang
Copy link
Contributor

jingleizhang commented Oct 28, 2022

Reply from Rodrigo:

The end result is we want to have a VC that says the user is a LIT Holder. Originally I was told that it would be too “Expensive” or too much work to check all accounts, so a specific account would be better to check. But if all accounts is easier/better, lets do that!

For the user the Quest would be:

- Connect any account that holds LIT (if you don’t have any already connected)
- Generate a VC to show that you are a LIT Holder

so in the VC generation we could check all

@Kailai-Wang
Copy link
Collaborator

so in the VC generation we could check all

So it actually means we want to check if any linked account (so main account excluded) holds any LIT

@Kailai-Wang Kailai-Wang transferred this issue from litentry/tee-worker Nov 29, 2022
@BillyWooo BillyWooo linked a pull request Nov 29, 2022 that will close this issue
@BillyWooo BillyWooo changed the title Build Ruleset 4: LIT Holder Build Assertion 4: LIT Holder Dec 1, 2022
@BillyWooo
Copy link
Collaborator

Discussed with @kaylawangnow , this requirement will be merged with #1024 . Both are querying LIT. Only give different timestamp as parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants