Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatePicker calendar view and DatePickerDialog #77

Closed
plfiorini opened this issue Feb 21, 2017 · 14 comments
Closed

DatePicker calendar view and DatePickerDialog #77

plfiorini opened this issue Feb 21, 2017 · 14 comments
Labels
Epic hacktoberfest Hacktoberfest help wanted Extra attention is needed
Milestone

Comments

@plfiorini
Copy link
Member

https://material.io/guidelines/components/pickers.html#pickers-date-pickers

@plfiorini plfiorini added this to the 0.11.0 milestone Feb 21, 2017
@plfiorini plfiorini added feature help wanted Extra attention is needed labels Feb 21, 2017
@crutchcorn
Copy link

crutchcorn commented Feb 21, 2017

Please wait. The current spec is mobile only

@plfiorini
Copy link
Member Author

@crutchcorn what's so mobile specific that cannot work on desktops?

@timsueberkrueb
Copy link
Contributor

timsueberkrueb commented Feb 21, 2017

@plfiorini Maybe we could allow editing dates/numbers manually to make it more desktop-friendly?
EDIT: e.g. like in a text field

@plfiorini
Copy link
Member Author

@tim-sueberkrueb a regular TextField with proper validator would be enough but that's a separate component

@plfiorini
Copy link
Member Author

Also the calendar view itself should be a DatePicker component that you can use where you want while DatePickerDialog is just a preconfigured dialog with proper sizing.

@plfiorini plfiorini changed the title DatePickerDialog DatePicker calendar view and DatePickerDialog Feb 21, 2017
@crutchcorn
Copy link

I my not be a MD official, but here's my guess:
It involves too much swiping and mobile based gestures. I think a calendar view based solution would be best. The less clicks and gestures needed the better

@crutchcorn
Copy link

Sorry, link was bad. Updated

@oKcerG
Copy link
Contributor

oKcerG commented Feb 21, 2017

It doesn't require swiping though, clicking the arrows to change the month and clicking the year to switch to year view can easily be done with a mouse.
I agree that it should at least on desktop be an editable textfield with an action icon (downward chevron or calendar icon) to pop up the picker.

@plfiorini
Copy link
Member Author

That's true but in my opinion the date picker is still usable on the desktop since you can press the left and right arrows, instead the year picker (or the time picker for that matters) is entirely gesture based.

@plfiorini plfiorini added the Epic label Feb 21, 2017
@plfiorini
Copy link
Member Author

Let's turn this issue into an Epic and break down to smaller tasks

@crutchcorn
Copy link

But it does, if you're following spec anyway; You have separate pages of date and years. This separation is not spatially wise on anything but mobile. Honestly the year field should be expanded to a dropdown, and the card should expand out IMO. See how the time picker expands on desktop

See how it expands out to have both on one page? That's being wise of your space and respecting the developers to do good with that space to make room for it

@automatedenergy
Copy link

Military time in a 0 -23 hr dropdown, and minutes in a 0-59 dropdown. Slider is nice.

@plfiorini plfiorini modified the milestones: Post 1.0, 0.11.0 May 14, 2017
@oKcerG
Copy link
Contributor

oKcerG commented Jul 20, 2017

md-datepicker was merged on 12 May : angular/components#4404
Overview in the doc : https://material.angular.io/components/datepicker

The official guidelines are still unchanged though.

@vimpostor
Copy link
Member

This one here could be helpful too: https://forum.qt.io/topic/82700/datepicker-anyone/

@plfiorini plfiorini added the hacktoberfest Hacktoberfest label Sep 28, 2017
@plfiorini plfiorini modified the milestones: Post 1.0, 0.11.0 Oct 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic hacktoberfest Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants