You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The shutdown function in BorrowerOperations is used to shut down the branch when the TCR falls below the SCR. If the branch is already shut down, the function will revert.
However, the function calls priceFeed.fetchPrice(), which can also shut down the branch if the price feed is failing.
This means that if the oracle fails at the same time that the branch's TCR falls below the SCR, the branch can be shut down twice. This will emit both the ShutDown and ShutDownFromOracleFailure events, which should be mutually exclusive and may not be handled correctly by off-chain infrastructure. There don't seem to be any other side effects, as the _applyShutdown will have no additional effect if it is called twice in the same block.
The text was updated successfully, but these errors were encountered:
The shutdown function in
BorrowerOperations
is used to shut down the branch when theTCR
falls below theSCR
. If the branch is already shut down, the function will revert.However, the function calls
priceFeed.fetchPrice()
, which can also shut down the branch if the price feed is failing.This means that if the oracle fails at the same time that the branch's
TCR
falls below theSCR
, the branch can be shut down twice. This will emit both theShutDown
andShutDownFromOracleFailure
events, which should be mutually exclusive and may not be handled correctly by off-chain infrastructure. There don't seem to be any other side effects, as the_applyShutdown
will have no additional effect if it is called twice in the same block.The text was updated successfully, but these errors were encountered: