Add forced focus option #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Kaspazza Thanks for your contribution!
Make sence! I'll have a look :) |
liquidz
requested changes
Sep 20, 2024
|
Thanks for the review @liquidz, I've applied your suggestions. |
|
@Kaspazza Thanks! I'll have a look this weekend :) |
|
@liquidz Done |
liquidz
approved these changes
Sep 29, 2024
|
@Kaspazza Just released v2.10.1241 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, it's me again.
We've been using previously programmatic API, but due to compatibility issues with Babashka, we've moved to CLI.
Currently, there is no option in CLI to force a specific version of the dependency to update.
Our use case to be more specific, is that we want to update to the non-existing yet version as we are deploying multiple co-dependent apps together. Which was possible in API by just supplying deps and target version we want it to update.
The CLI focus option seems best for me for that feature, as we want to focus on that dependency and update it to a specific version.
In terms of syntax, exclude follows a similar syntax of being able to exclude dep completely or specific version, currently focus was not leveraging the version option, so I've added this behavior under that versioning syntax.
--focus=artifact[@VERSION]The feature was implemented in a manner that should not affect any existing behaviors that user may call. This is completely separate new feature.
Previously calling focus with
[@VERSION]will result in empty deps to update, as it was considering whole string as a dependency name. Now if@appears, it considers it as forced-focus feature, otherwise as it was previously.Example usage is described in .md and tests.
I use it like that:
Let's assume current version of artifact
org.clojars.hephaistox/automaton-buildin clojars is 3.1.0I run
clojure -M:antq --upgrade --force --focus=org.clojars.hephaistox/[email protected]And in my deps.edn, I expect all references to org.clojars.hephaistox/automaton-build to be updated to 3.2.0
So whatever is set after @ in focus options is treated as source of truth for new version setting.