Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependabot bundler only considers the main go.mod files #657

Closed
Skarlso opened this issue Mar 5, 2023 · 3 comments · Fixed by #662
Closed

Dependabot bundler only considers the main go.mod files #657

Skarlso opened this issue Mar 5, 2023 · 3 comments · Fixed by #662
Labels
kind/bug Something isn't working kind/feature New feature or request

Comments

@Skarlso
Copy link
Contributor

Skarlso commented Mar 5, 2023

I was wondering why some of the changes didn't happen in the bundler PR. And now it dawned on me.

The bundler only updates the go.mod file in the root. And the dependabot PRs are for hack/tools. That's why it didn't bundle them.
@Skarlso Skarlso added the kind/bug Something isn't working label Mar 5, 2023
@Skarlso Skarlso mentioned this issue Mar 5, 2023
Open
@Skarlso Skarlso added the kind/feature New feature or request label Mar 5, 2023
@Skarlso
Copy link
Contributor Author

Skarlso commented Mar 5, 2023

I can't decide if this is a bug or a feature. :)

@Skarlso
Copy link
Contributor Author

Skarlso commented Mar 5, 2023

Skarlso/dependabot-bundler#26 will take care of this

@Skarlso Skarlso mentioned this issue Mar 7, 2023
Merged
4 tasks
@Skarlso
Copy link
Contributor Author

Skarlso commented Mar 7, 2023

Yaaaay works \o/

#663

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working kind/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(deps): update the bundler to new version liquidmetal-dev/flintlock
1 participant
@Skarlso