Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I should be able to delete an mvm even if it has not finished creating yet #314

Open
Callisto13 opened this issue Dec 9, 2021 · 5 comments
Labels
good first issue Good for newcomers kind/bug Something isn't working

Comments

@Callisto13
Copy link
Member

What happened:
I created an MVM and it failed to start properly and was on its 6th attempt of the reconciliation loop.
I tried to delete it, but the delete only went through after the 10th create attempt had been made.

What did you expect to happen:
A delete should delete regardless of the created state of the mvm, or what stage of the process it is in.

How to reproduce it:
Make reconciliation fail any old how (messing up IfaceCreate is a good one), call create, then delete before recons get to 10/10.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • flintlock version:
  • containerd version:
  • OS (e.g. from /etc/os-release):
@Callisto13 Callisto13 added the kind/bug Something isn't working label Dec 9, 2021
@Callisto13
Copy link
Member Author

Actually this is fine, just really really slow. Will be less of a problem when we get #310 in.

@Callisto13
Copy link
Member Author

Actually this is a problem. Minor, but still.

When I call delete and the current plan is sat waiting for the next retry attempt, the delete will not be registered until the next reschedule. When you are near the end of attempts (like on 9) this can be a really long time.

Ideally a delete should be able to cancel that wait.

@Callisto13 Callisto13 reopened this Dec 14, 2021
@Callisto13 Callisto13 assigned Callisto13 and unassigned Callisto13 Dec 14, 2021
@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 14, 2022
@Callisto13 Callisto13 removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 14, 2022
@Callisto13 Callisto13 added the good first issue Good for newcomers label May 23, 2022
@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 19, 2023
Copy link
Contributor

This issue was closed because it has been stalled for 365 days with no activity.

@github-actions github-actions bot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label May 18, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Closed in Liquid Metal Roadmap - Public May 18, 2024
@richardcase richardcase reopened this Jul 10, 2024
@richardcase richardcase removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers kind/bug Something isn't working
Projects
No open projects
Status: Closed
Development

No branches or pull requests

2 participants