Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry counter on failed reconciliation #232

Closed
yitsushi opened this issue Nov 9, 2021 · 0 comments · Fixed by #255
Closed

Add retry counter on failed reconciliation #232

yitsushi opened this issue Nov 9, 2021 · 0 comments · Fixed by #255
Assignees
Labels
kind/feature New feature or request priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.

Comments

@yitsushi
Copy link
Contributor

yitsushi commented Nov 9, 2021

Describe the solution you'd like:
Right we we have code to abort reconciliation for a VM if it failed N times, but we never set the Retried field.

Why do you want this feature:
If something is wrong, we get an infinite reconciliation loop. It would be nice if the system would stop doing it after N failures and clean the Retries field on successful reconciliation.

Anything else you would like to add:
nothing

@yitsushi yitsushi added the kind/feature New feature or request label Nov 9, 2021
@richardcase richardcase added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Nov 10, 2021
@yitsushi yitsushi self-assigned this Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants