Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only delete MicroVMs if state is CREATED or PENDING #83

Closed
Callisto13 opened this issue Jan 10, 2022 · 1 comment · Fixed by #85
Closed

Only delete MicroVMs if state is CREATED or PENDING #83

Callisto13 opened this issue Jan 10, 2022 · 1 comment · Fixed by #85
Assignees
Labels
kind/bug Something isn't working

Comments

@Callisto13
Copy link
Member

Callisto13 commented Jan 10, 2022

Currently when deleting a microvm machine we Get the mvm and check if it is not nil and then delete.

But, we should only issue a delete request to mvms that are not already deleting.

The states on an MVM are:

  • CREATED
  • PENDING
  • DELETING
@Callisto13 Callisto13 added the kind/bug Something isn't working label Jan 10, 2022
@Callisto13
Copy link
Member Author

the other half of liquidmetal-dev/flintlock#310

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants