Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement delayed cleanup support #93

Closed
4 tasks done
zanerock opened this issue Mar 20, 2024 · 1 comment · Fixed by #102
Closed
4 tasks done

Implement delayed cleanup support #93

zanerock opened this issue Mar 20, 2024 · 1 comment · Fixed by #102
Assignees
Labels
assigned This task has been assigned/claimed. enhancement New feature or request
Milestone

Comments

@zanerock
Copy link
Member

zanerock commented Mar 20, 2024

Overview

When stacks are destroyed, you can't always delete everything right away. So, when the delete fails, we want to go ahead and delete the sites (assuming #92 is done first) entry because the site is no longer valid. We transfer the site data to a toCleanup array

We would then implement a 'cleanup' command that will iterate through toCleanup sites (or, delete the specified site) and try to delete them. If unsuccessful, add/update a lastCleanupAttempt for the item entry.

Deliverables

  • Implement cleanup (all)
  • Implement cleanup XXX
  • Implement cleanup --list which will list the sites, if any
  • make on entry in reminders and remove entry once site is deleted
@zanerock zanerock added the enhancement New feature or request label Mar 20, 2024
@zanerock zanerock added this to the 1.0.0-rc milestone Mar 20, 2024
@zanerock zanerock added the assigned This task has been assigned/claimed. label Mar 21, 2024
@zanerock
Copy link
Member Author

Work for this issue will begin begin on branch work-liquid-labs/cloudsite/93.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned This task has been assigned/claimed. enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant