-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(DAT-18853): Add custom diff change generator for Databricks #203
Conversation
- Added `ChangedTableChangeGeneratorDatabricks` class to handle Databricks-specific table property changes. - Implemented logic to compare and generate changes for table properties. - Updated `META-INF/services/liquibase.diff.output.changelog.ChangeGenerator` to include the new change generator.
@KushnirykOleh any idea on how to add tests here? |
diff-changelog test from test-harness doesn't work properly in extensions. To check parsing I would only add unit test with Strings that looks like these Lines 7 to 16 in 2cd2f40
|
Thanks! |
- Added filters to ensure only valid key-value pairs are processed. - added `ChangedTblPropertiesUtilTest`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks legit
- Added filters to ensure only valid key-value pairs are processed. - Updated `ChangedTblPropertiesUtilTest` to include the necessary imports and package declaration. - Added a new test case to validate that internal delta properties are ignored
Quality Gate passedIssues Measures |
ChangedTableChangeGeneratorDatabricks
class to handle Databricks-specific table property changes.META-INF/services/liquibase.diff.output.changelog.ChangeGenerator
to include the new change generator.