Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add option to avoid creating footprints TDE-1159 #959

Merged
merged 1 commit into from
May 6, 2024

Conversation

l0b0
Copy link
Contributor

@l0b0 l0b0 commented May 5, 2024

Motivation

Give the user control of whether we create footprints for tiles. This is a workaround for some footprints resulting in unusably complex capture areas.

Modification

Add flag to control whether footprints (and therefore capture areas) are created.

We had to use a mandatory flag to workaround not finding how to conditionally pass arguments with Argo Workflows.

Checklist

  • Tests updated
  • Docs updated
  • Issue linked in Title

@l0b0 l0b0 force-pushed the feat/give-option-create-footprints-tde-1159 branch from 0c5f1b0 to d5893a6 Compare May 5, 2024 23:27
@l0b0 l0b0 marked this pull request as ready for review May 5, 2024 23:28
@l0b0 l0b0 requested a review from a team as a code owner May 5, 2024 23:28
@l0b0
Copy link
Contributor Author

l0b0 commented May 5, 2024

Manually tested:

docker run -v ${HOME}/tmp/:/tmp/:rw topo-imagery python standardise_validate.py --preset webp --from-file ./tests/data/aerial.json --collection-id 123 --start-datetime 2023-01-01 --end-datetime 2023-01-01 --target /tmp/ --source-epsg 2193 --target-epsg 2193 --gsd 10m --create-footprints=false
# Did not create a footprint
$ docker run -v ${HOME}/tmp/:/tmp/:rw topo-imagery python standardise_validate.py --preset webp --from-file ./tests/data/aerial.json --collection-id 123 --start-datetime 2023-01-01 --end-datetime 2023-01-01 --target /tmp/ --source-epsg 2193 --target-epsg 2193 --gsd 10m --create-footprints=true
# Created a footprint

Only the specified values are accepted:

❯ docker run -v ${HOME}/tmp/:/tmp/:rw topo-imagery python standardise_validate.py --preset webp --from-file ./tests/data/aerial.json --collection-id 123 --start-datetime 2023-01-01 --end-datetime 2023-01-01 --target /tmp/ --source-epsg 2193 --target-epsg 2193 --gsd 10m --create-footprints=True
usage: standardise_validate.py [-h] --preset PRESET --from-file FROM_FILE
                               --source-epsg SOURCE_EPSG --target-epsg
                               TARGET_EPSG --gsd GSD --create-footprints
                               CREATE_FOOTPRINTS [--cutline [CUTLINE]]
                               --collection-id COLLECTION_ID --start-datetime
                               START_DATETIME --end-datetime END_DATETIME
                               --target TARGET
standardise_validate.py: error: argument --create-footprints: Invalid boolean (must be exactly 'true' or 'false'): True

@l0b0 l0b0 changed the title feat: add option to create footprints TDE-1159 feat!: add option to create footprints TDE-1159 May 6, 2024
@l0b0 l0b0 enabled auto-merge May 6, 2024 00:02
l0b0 added a commit to linz/topo-workflows that referenced this pull request May 6, 2024
@l0b0 l0b0 marked this pull request as draft May 6, 2024 00:07
auto-merge was automatically disabled May 6, 2024 00:07

Pull request was converted to draft

@l0b0 l0b0 force-pushed the feat/give-option-create-footprints-tde-1159 branch from 8cbf90a to fa97e68 Compare May 6, 2024 00:15
@l0b0 l0b0 changed the title feat!: add option to create footprints TDE-1159 feat: add option to create footprints TDE-1159 May 6, 2024
@l0b0 l0b0 marked this pull request as ready for review May 6, 2024 00:16
@paulfouquet paulfouquet changed the title feat: add option to create footprints TDE-1159 feat: add option to avoid creating footprints TDE-1159 May 6, 2024
@l0b0 l0b0 force-pushed the feat/give-option-create-footprints-tde-1159 branch from fa97e68 to 2c0e320 Compare May 6, 2024 03:19
@l0b0 l0b0 changed the title feat: add option to avoid creating footprints TDE-1159 feat!: add option to avoid creating footprints TDE-1159 May 6, 2024
Co-Authored-By: Victor Engmark <[email protected]>
Co-Authored-By: Alice Fage <[email protected]>
Co-Authored-By: Megan Davidson <[email protected]>
@l0b0 l0b0 force-pushed the feat/give-option-create-footprints-tde-1159 branch from 2c0e320 to 5b240e7 Compare May 6, 2024 21:06
@l0b0 l0b0 enabled auto-merge May 6, 2024 21:38
@paulfouquet
Copy link
Collaborator

We had to use a mandatory flag to workaround not finding how to conditionally pass arguments with Argo Workflows

@l0b0 l0b0 added this pull request to the merge queue May 6, 2024
Merged via the queue into master with commit ea5c98b May 6, 2024
2 checks passed
@l0b0 l0b0 deleted the feat/give-option-create-footprints-tde-1159 branch May 6, 2024 21:52
@github-actions github-actions bot mentioned this pull request May 3, 2024
l0b0 added a commit to linz/topo-workflows that referenced this pull request May 6, 2024
github-merge-queue bot pushed a commit to linz/topo-workflows that referenced this pull request May 7, 2024
#### Motivation

Give the user control of whether we create capture areas for datasets.
This is a workaround for some footprints resulting in unusably complex
capture areas.

#### Modification

New `create_capture_area` parameter, passed through as
`--create-footprints`.

Depends on <linz/topo-imagery#959>.

#### Checklist

- [ ] Tests updated (N/A)
- [x] Docs updated
- [x] Issue linked in Title
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants