generated from linz/template-python-hello-world
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add option to avoid creating footprints TDE-1159 #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l0b0
force-pushed
the
feat/give-option-create-footprints-tde-1159
branch
from
May 5, 2024 23:27
0c5f1b0
to
d5893a6
Compare
Manually tested:
Only the specified values are accepted:
|
l0b0
changed the title
feat: add option to create footprints TDE-1159
feat!: add option to create footprints TDE-1159
May 6, 2024
l0b0
added a commit
to linz/topo-workflows
that referenced
this pull request
May 6, 2024
auto-merge was automatically disabled
May 6, 2024 00:07
Pull request was converted to draft
l0b0
force-pushed
the
feat/give-option-create-footprints-tde-1159
branch
from
May 6, 2024 00:15
8cbf90a
to
fa97e68
Compare
l0b0
changed the title
feat!: add option to create footprints TDE-1159
feat: add option to create footprints TDE-1159
May 6, 2024
paulfouquet
changed the title
feat: add option to create footprints TDE-1159
feat: add option to avoid creating footprints TDE-1159
May 6, 2024
l0b0
force-pushed
the
feat/give-option-create-footprints-tde-1159
branch
from
May 6, 2024 03:19
fa97e68
to
2c0e320
Compare
l0b0
changed the title
feat: add option to avoid creating footprints TDE-1159
feat!: add option to avoid creating footprints TDE-1159
May 6, 2024
3 tasks
Co-Authored-By: Victor Engmark <[email protected]> Co-Authored-By: Alice Fage <[email protected]> Co-Authored-By: Megan Davidson <[email protected]>
l0b0
force-pushed
the
feat/give-option-create-footprints-tde-1159
branch
from
May 6, 2024 21:06
2c0e320
to
5b240e7
Compare
paulfouquet
approved these changes
May 6, 2024
We had to use a mandatory flag to workaround not finding how to conditionally pass arguments with Argo Workflows |
MDavidson17
approved these changes
May 6, 2024
Merged
l0b0
added a commit
to linz/topo-workflows
that referenced
this pull request
May 6, 2024
It may no longer be created as part of <linz/topo-imagery#959>.
github-merge-queue bot
pushed a commit
to linz/topo-workflows
that referenced
this pull request
May 7, 2024
#### Motivation Give the user control of whether we create capture areas for datasets. This is a workaround for some footprints resulting in unusably complex capture areas. #### Modification New `create_capture_area` parameter, passed through as `--create-footprints`. Depends on <linz/topo-imagery#959>. #### Checklist - [ ] Tests updated (N/A) - [x] Docs updated - [x] Issue linked in Title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Give the user control of whether we create footprints for tiles. This is a workaround for some footprints resulting in unusably complex capture areas.
Modification
Add flag to control whether footprints (and therefore capture areas) are created.
We had to use a mandatory flag to workaround not finding how to conditionally pass arguments with Argo Workflows.
Checklist