feat: title and description by arguments TDE-960 #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
l0b0
reviewed
Dec 3, 2023
l0b0
reviewed
Dec 7, 2023
l0b0
reviewed
Dec 7, 2023
l0b0
reviewed
Dec 7, 2023
l0b0
reviewed
Dec 7, 2023
l0b0
previously approved these changes
Dec 11, 2023
blacha
reviewed
Dec 13, 2023
l0b0
previously approved these changes
Dec 18, 2023
amfage
reviewed
Dec 19, 2023
l0b0
previously approved these changes
Dec 19, 2023
amfage
previously approved these changes
Dec 19, 2023
to match metadata name and basemaps
Co-authored-by: Alice Fage <[email protected]>
MDavidson17
force-pushed
the
feat/title-by-arguments
branch
from
0c21059 to
bc46027
Compare
amfage
approved these changes
Dec 19, 2023
l0b0
approved these changes
Dec 19, 2023
Merged
github-merge-queue bot
pushed a commit
to linz/topo-workflows
that referenced
this pull request
Dec 19, 2023
…le and description TDE-955 (#323) #### Motivation Entering/typing a title or description for imagery datasets is currently inefficient and risky. To remove the risk the title & description should be automatically generated using input parameters. #### Modification imagery-standardising workflow updated to take: `gsd`, `subtype`, `location`, `event`, `historic-survey-number` and `lifecycle` parameters. create-collection step updated to take above parameters and `region`, `start-datetime` and `end-datetime` standardise-publish-import workflow updated ascii-standardise-publish workflow updated #### Checklist _If not applicable, provide explanation of why._ - [x] Tests updated - no tests - [x] Docs updated - [x] Issue linked in Title Should not be merged before linz/topo-imagery#757 is merged & released --------- Co-authored-by: paulfouquet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Entering/typing a title or description for imagery datasets is currently inefficient and risky. To remove the risk the title & description should be automatically generated using input parameters.
Modification
collection_from_items.py updated to take:
region,gsd,subtype,location,start-datetime,end-datetime,event,historic-survey-numberandlifecycleparameters.automation logic written in new file:
generate_metadata.pyNB: the tests provide a good over of the different title / description logic
Checklist
If not applicable, provide explanation of why.
PR Topo-workflows to be merged after this PR has been released
PR ADDING METADATA TO COLLECTION.JSON TO COME