fix: capture area rounding TDE-1237 #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amfage
requested review from
l0b0,
blacha,
MDavidson17 and
paulfouquet
and removed request for
MDavidson17
l0b0
approved these changes
Oct 9, 2024
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 9, 2024
🤖 I have created a release *beep* *boop* --- ## [5.0.2](v5.0.1...v5.0.2) (2024-10-09) ### Bug Fixes * capture area rounding TDE-1237 ([#1116](#1116)) ([d055f49](d055f49)) * providers should not be duplicated when having different roles TDE-1286 ([#1115](#1115)) ([46303cb](46303cb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Although the footprint files are rounded to 8 decimal places, when they are combined into a capture area this can create some co-ordinates with more than 8 decimal places, which we then need to round.
Modifications
Use Shapely to round the co-ordinates to 8 decimal places after merging the footprint geometries.
Verification
Unit test created, unit tests updated for new capture area rounding.
Manually compared capture-area-compare.zip.