Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make start_datetime and end_datetime optional when includeDerived is True TDE-1258 #1065

Conversation

paulfouquet
Copy link
Collaborator

@paulfouquet paulfouquet commented Sep 11, 2024

Motivation

start_datetime and end_datetime should be optional in the case of the output tiles include derived items.

Modifications

  • make the input parameters not always required

Verification

Ran a couple of test workflows with the following:

  • empty datetimes
  • bad format datetime
  • good format datetime

@paulfouquet paulfouquet added the container Publish a container label Sep 11, 2024
@paulfouquet paulfouquet added container Publish a container and removed container Publish a container labels Sep 12, 2024
@paulfouquet paulfouquet marked this pull request as ready for review September 12, 2024 02:32
@paulfouquet paulfouquet requested a review from a team as a code owner September 12, 2024 02:32
@paulfouquet paulfouquet added this pull request to the merge queue Sep 12, 2024
Merged via the queue into master with commit 57f088c Sep 12, 2024
2 checks passed
@paulfouquet paulfouquet deleted the feat/start-end-datetime-optional-for-include-derived-tde-1258 branch September 12, 2024 03:10
@github-actions github-actions bot mentioned this pull request Sep 12, 2024
github-merge-queue bot pushed a commit that referenced this pull request Sep 12, 2024
🤖 I have created a release *beep* *boop*
---


##
[4.10.0](v4.9.0...v4.10.0)
(2024-09-12)


### Features

* add derived_from links to item TDE-1251
([#1043](#1043))
([077f14f](077f14f))
* determine start and end datetimes when item include derived TDE-1258
([#1052](#1052))
([62d571a](62d571a))
* make start_datetime and end_datetime optional when includeDerived is
True TDE-1258
([#1065](#1065))
([57f088c](57f088c))
* More types ([#989](#989))
([3f7cd57](3f7cd57))


### Bug Fixes

* capture area winding order TDE-1205
([#1008](#1008))
([61be096](61be096))
* error on collection with no items TDE-1216
([#1000](#1000))
([d351d85](d351d85))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
container Publish a container
Development

Successfully merging this pull request may close these issues.

2 participants