Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizing Performance and Resource Utilization with Concurrent Asynchronous Execution 🚤 #501

Closed
wants to merge 1 commit into from
Closed

Optimizing Performance and Resource Utilization with Concurrent Asynchronous Execution 🚤 #501

wants to merge 1 commit into from

Conversation

sanjaiyan-dev
Copy link

Hello,

I anticipated that this pull request would bring about performance improvements and enhanced hardware resource efficiency by utilizing Promise.all to execute the task.

There is a related pull request in Deno, although not identical, that demonstrated a performance improvement of nearly 85% during benchmarking: link to the Deno pull request.

Extremely sorry, if I made any mistakes :)

@sanjaiyan-dev sanjaiyan-dev requested a review from a team as a code owner December 13, 2023 08:24
@sanjaiyan-dev sanjaiyan-dev requested review from blacha and Wentao-Kuang and removed request for a team December 13, 2023 08:24
@blacha
Copy link
Member

blacha commented Dec 13, 2023

Hi @sanjaiyan-dev This breaks the main function of the command.

The tar creation process needs to be run in the specific order, the goal of the tar creation is to be reproducible, so if you give it a list of files should always be added to the tar in the same exact order.

By making this concurrent the files can be written to the tar in a somewhat random order.

@blacha blacha closed this Dec 13, 2023
@sanjaiyan-dev sanjaiyan-dev deleted the sanjaiyan-async-concurrent branch December 13, 2023 20:56
@sanjaiyan-dev
Copy link
Author

Hi @sanjaiyan-dev This breaks the main function of the command.

The tar creation process needs to be run in the specific order, the goal of the tar creation is to be reproducible, so if you give it a list of files should always be added to the tar in the same exact order.

By making this concurrent the files can be written to the tar in a somewhat random order.

Understood and extremely sorry for the inconvenience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants