Supercharge Performance & Efficiency: Leveraging Promise.all for Resource-Friendly Tasks 🚤
#797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanjaiyan-dev
requested review from
l0b0,
amfage,
MDavidson17,
paulfouquet and
Wentao-Kuang
|
While I appreciate the effort of trying to improve the performance here, Most of the time for this command is spent in the validation phase. Writing these files out at the end concurrently would not affect the overall performance of the command. |
sanjaiyan-dev
changed the title
Promise.all for Resource-Friendly Tasks 🚤
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I believe this pull request has the potential to significantly improve performance and resource efficiency by leveraging
Promise.allfor parallel execution.While not directly comparable, a similar pull request in Deno achieved a nearly 85% performance boost in their benchmarks. You can find the Deno PR here: [https://github.com/denoland/std/pull/3363].
Please let me know if you have any questions or feedback. I'm always happy to improve !