Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending Camera folder to PC erases existing folder on PC #205

Open
tonywhelan opened this issue Jan 27, 2024 · 4 comments
Open

Sending Camera folder to PC erases existing folder on PC #205

tonywhelan opened this issue Jan 27, 2024 · 4 comments

Comments

@tonywhelan
Copy link

tonywhelan commented Jan 27, 2024

History: refer https://forums.linuxmint.com/viewtopic.php?p=2424201#p2424201

My new PC has Mint 21.3 Cinnamon, Warpinator v1.8.3
My Android phone has warpinator v1.7

Sending the folder "Camera" from my Android phone works. If I delete those files from the phone, take some more pics, then use warpinator to send the Camera folder to the PC, it wipes out the files that had previously been transferred to the PC.

"Require approval when files would be overwritten" is off. But it isn't overwriting files of same name, it is erasing existing files with different names.

I would expect the program to copy the new files into the target folder without deleting existing files

@CaptainSalami
Copy link

I have the exact same problem.

@carlosmintfan
Copy link
Contributor

So warpinator should check whether the file to overwrite is a folder and if it is, just add the new files into it. However, can you thik of any situation where the user would expect the existing folder to be overwritten?

@yumpyy
Copy link

yumpyy commented Jul 26, 2024

https://github.com/linuxmint/warpinator/blob/34413b665559c96f8ccc4bff5856d180e02777f6/src/transfers.py#L189C1-L193C35
looks like this blob is responsible for overwriting folders/files with same names.

@carlosmintfan
Copy link
Contributor

@mtwebster wants it to be like that so you don't accidentally get some files in an existing folder with applications or so...but it should be clarified in the settings to "overwrite files and folders"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants