Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regenerate the model from R4B (4.3.0) spec artifacts #2066

Closed
lmsurpre opened this issue Mar 11, 2021 · 5 comments
Closed

Regenerate the model from R4B (4.3.0) spec artifacts #2066

lmsurpre opened this issue Mar 11, 2021 · 5 comments
Assignees
@lmsurpre
Labels
P3 Priority 3 - Nice To Have r4b specification

Comments

@lmsurpre
Copy link
Member

No description provided.

@lmsurpre lmsurpre added the P3 Priority 3 - Nice To Have label May 17, 2021
@lmsurpre lmsurpre changed the title Regenerate the model from 4.1.0 spec artifacts Regenerate the model from R4B (4.3.0) spec artifacts Oct 19, 2021
@vikforfda
Copy link

As part of integrating R4B spec to current version of IBM-FHIR release, performed following steps

  • downloaded the JSOn specification from the web site http://hl7.org/fhir/2021Mar/downloads.html

  • unzipped the downloaded R4B specification and used it to replace the existing FHIR specification files in fhir-tools project. I had to reuse the existing v3-codesystems.json from the current release with the R4B specification files as it did not exist in the unzipped R4B specification

  • generated the fhir-model project by running the build/gen-model.sh script. I had to make multiple changes in fhir-tools/CodeGenerator.java module to resolve the initial set of compilation errors in the generated fhir-model project.

The updated CodeGenerator.java is attached. Also note that there is a compilation error in generated ConceptSubsumptionOutcome.java for which Lee created an issue in the FHIR community (refer https://chat.fhir.org/#narrow/stream/179166-implementers/topic/R4B.20missing.20valueset.3F)
CodeGenerator.java.zip

@lmsurpre
Copy link
Member Author

I think I was able to find the necessary codesystems and valuesets from the valueset.json in the main defintions package and a separate "expansions.json" file from a different download from the same page: https://build.fhir.org/branches/R4B/downloads.html

Unfortunately, when I used these files, I bumped into https://jira.hl7.org/browse/FHIR-34303
I will need to workaround that to proceed, but its quite doable.

@lmsurpre lmsurpre self-assigned this Nov 15, 2021
@lmsurpre lmsurpre added this to the Sprint 2021-16 milestone Nov 15, 2021
@lmsurpre
Copy link
Member Author

hit another related issue: post at https://chat.fhir.org/#narrow/stream/179166-implementers/topic/R4B.20missing.20valueset.3F/near/261548739 but will probably open a jira for this one too.

lmsurpre added a commit that referenced this issue Nov 15, 2021
@lmsurpre
issue #2066 - fhir-tools updates for generating code from R4B
7808db4 
* added R4BModelGeneratorImpl and updated ModelFactory to support that.
* moved current definitions under R4 dir and introduced R4B dir for the
spec artifacts
  * added fhir-expansions from the expansions download of the R4B spec
  * added R4B/terminology for other one-off CodeSystem and ValueSet
resources that used to be packaged with the base spec
* use a set instead of a list for codesystem values to workaround
duplicate values in the base spec ResourceType definition
(https://jira.hl7.org/browse/FHIR-34303)

Signed-off-by: Lee Surprenant <[email protected]>
@lmsurpre lmsurpre mentioned this issue Nov 15, 2021
Closed
lmsurpre added a commit that referenced this issue Nov 16, 2021
@lmsurpre
issue #2066 - fhir-tools updates for generating code from R4B
6bd122f 
* added R4BModelGeneratorImpl and updated ModelFactory to support that.
* moved current definitions under R4 dir and introduced R4B dir for the
spec artifacts
  * added fhir-expansions from the expansions download of the R4B spec
  * added R4B/terminology for other one-off CodeSystem and ValueSet
resources that used to be packaged with the base spec
* use a set instead of a list for codesystem values to workaround
duplicate values in the base spec ResourceType definition
(https://jira.hl7.org/browse/FHIR-34303)

Signed-off-by: Lee Surprenant <[email protected]>
lmsurpre added a commit that referenced this issue Dec 2, 2021
@lmsurpre
issue #2066 - fhir-tools updates for generating code from R4B
873dbe2 
* added R4BModelGeneratorImpl and updated ModelFactory to support that.
* moved current definitions under R4 dir and introduced R4B dir for the
spec artifacts
  * added fhir-expansions from the expansions download of the R4B spec
  * added R4B/terminology for other one-off CodeSystem and ValueSet
resources that used to be packaged with the base spec
* use a set instead of a list for codesystem values to workaround
duplicate values in the base spec ResourceType definition
(https://jira.hl7.org/browse/FHIR-34303)

Signed-off-by: Lee Surprenant <[email protected]>
lmsurpre added a commit that referenced this issue Dec 6, 2021
@lmsurpre
issue #2066 - fhir-tools updates for generating code from R4B
2e9bd82 
* added R4BModelGeneratorImpl and updated ModelFactory to support that.
* moved current definitions under R4 dir and introduced R4B dir for the
spec artifacts
  * added fhir-expansions from the expansions download of the R4B spec
  * added R4B/terminology for other one-off CodeSystem and ValueSet
resources that used to be packaged with the base spec
* use a set instead of a list for codesystem values to workaround
duplicate values in the base spec ResourceType definition
(https://jira.hl7.org/browse/FHIR-34303)

Signed-off-by: Lee Surprenant <[email protected]>
lmsurpre added a commit that referenced this issue Dec 6, 2021
@lmsurpre
issue #2066 - fhir-tools updates for generating code from R4B
4e89c32 
* added R4BModelGeneratorImpl and updated ModelFactory to support that.
* moved current definitions under R4 dir and introduced R4B dir for the
spec artifacts
  * added fhir-expansions from the expansions download of the R4B spec
  * added R4B/terminology for other one-off CodeSystem and ValueSet
resources that used to be packaged with the base spec
* use a set instead of a list for codesystem values to workaround
duplicate values in the base spec ResourceType definition
(https://jira.hl7.org/browse/FHIR-34303)

Signed-off-by: Lee Surprenant <[email protected]>
lmsurpre added a commit that referenced this issue Dec 8, 2021
@lmsurpre
issue #2066 - fhir-tools updates for generating code from R4B
02df4b2 
* added R4BModelGeneratorImpl and updated ModelFactory to support that.
* moved current definitions under R4 dir and introduced R4B dir for the
spec artifacts
  * added fhir-expansions from the expansions download of the R4B spec
  * added R4B/terminology for other one-off CodeSystem and ValueSet
resources that used to be packaged with the base spec
* use a set instead of a list for codesystem values to workaround
duplicate values in the base spec ResourceType definition
(https://jira.hl7.org/browse/FHIR-34303)

Signed-off-by: Lee Surprenant <[email protected]>
lmsurpre added a commit that referenced this issue Dec 8, 2021
@lmsurpre
issue #2066 - fhir-tools updates for generating code from R4B
66e0f6b 
* added R4BModelGeneratorImpl and updated ModelFactory to support that.
* moved current definitions under R4 dir and introduced R4B dir for the
spec artifacts
  * added fhir-expansions from the expansions download of the R4B spec
  * added R4B/terminology for other one-off CodeSystem and ValueSet
resources that used to be packaged with the base spec
* use a set instead of a list for codesystem values to workaround
duplicate values in the base spec ResourceType definition
(https://jira.hl7.org/browse/FHIR-34303)

Signed-off-by: Lee Surprenant <[email protected]>
lmsurpre added a commit that referenced this issue Dec 13, 2021
@lmsurpre
issue #2066 - fhir-tools updates for generating code from R4B
c6734d5 
* added R4BModelGeneratorImpl and updated ModelFactory to support that.
* moved current definitions under R4 dir and introduced R4B dir for the
spec artifacts
  * added fhir-expansions from the expansions download of the R4B spec
  * added R4B/terminology for other one-off CodeSystem and ValueSet
resources that used to be packaged with the base spec
* use a set instead of a list for codesystem values to workaround
duplicate values in the base spec ResourceType definition
(https://jira.hl7.org/browse/FHIR-34303)

Signed-off-by: Lee Surprenant <[email protected]>
@lmsurpre
Copy link
Member Author

this was done for the current snapshot for FHIR R4B in our r4b branch. we'll need to redo it once they take a snapshot for the upcoming connectathon. instead of opening a new issue for it, I'll just move this one to the next sprint

@lmsurpre lmsurpre removed this from the Sprint 2021-16 milestone Dec 16, 2021
lmsurpre added a commit that referenced this issue Dec 17, 2021
@lmsurpre
issue #2066 - fhir-tools updates for generating code from R4B
ed3f828 
* added R4BModelGeneratorImpl and updated ModelFactory to support that.
* moved current definitions under R4 dir and introduced R4B dir for the
spec artifacts
  * added fhir-expansions from the expansions download of the R4B spec
  * added R4B/terminology for other one-off CodeSystem and ValueSet
resources that used to be packaged with the base spec
* use a set instead of a list for codesystem values to workaround
duplicate values in the base spec ResourceType definition
(https://jira.hl7.org/browse/FHIR-34303)

Signed-off-by: Lee Surprenant <[email protected]>
lmsurpre added a commit that referenced this issue Jan 4, 2022
@lmsurpre
issue #2066 - fhir-tools updates for generating code from R4B
7386ceb 
* added R4BModelGeneratorImpl and updated ModelFactory to support that.
* moved current definitions under R4 dir and introduced R4B dir for the
spec artifacts
  * added fhir-expansions from the expansions download of the R4B spec
  * added R4B/terminology for other one-off CodeSystem and ValueSet
resources that used to be packaged with the base spec
* use a set instead of a list for codesystem values to workaround
duplicate values in the base spec ResourceType definition
(https://jira.hl7.org/browse/FHIR-34303)

Signed-off-by: Lee Surprenant <[email protected]>
@lmsurpre
Copy link
Member Author

lmsurpre commented Jan 4, 2022 •
edited
Loading

I updated my r4b branch with the latest 4.3.0-CIBUILD version.
We'll need to update it one more time once 4.3.0 is published, but I'd like to call this one complete now, so
I opened #3150 for the final update.

@lmsurpre lmsurpre closed this as completed Jan 4, 2022
lmsurpre added a commit that referenced this issue Jan 12, 2022
@lmsurpre
issue #2066 - fhir-tools updates for generating code from R4B
c2807b9 
* added R4BModelGeneratorImpl and updated ModelFactory to support that.
* moved current definitions under R4 dir and introduced R4B dir for the
spec artifacts
  * added fhir-expansions from the expansions download of the R4B spec
  * added R4B/terminology for other one-off CodeSystem and ValueSet
resources that used to be packaged with the base spec
* use a set instead of a list for codesystem values to workaround
duplicate values in the base spec ResourceType definition
(https://jira.hl7.org/browse/FHIR-34303)

Signed-off-by: Lee Surprenant <[email protected]>
lmsurpre added a commit that referenced this issue Jan 14, 2022
@lmsurpre
issue #2066 - fhir-tools updates for generating code from R4B
d1bcc6f 
* added R4BModelGeneratorImpl and updated ModelFactory to support that.
* moved current definitions under R4 dir and introduced R4B dir for the
spec artifacts
  * added fhir-expansions from the expansions download of the R4B spec
  * added R4B/terminology for other one-off CodeSystem and ValueSet
resources that used to be packaged with the base spec
* use a set instead of a list for codesystem values to workaround
duplicate values in the base spec ResourceType definition
(https://jira.hl7.org/browse/FHIR-34303)

Signed-off-by: Lee Surprenant <[email protected]>
lmsurpre added a commit that referenced this issue Jan 20, 2022
@lmsurpre
issue #2066 - fhir-tools updates for generating code from R4B
241710f 
* added R4BModelGeneratorImpl and updated ModelFactory to support that.
* moved current definitions under R4 dir and introduced R4B dir for the
spec artifacts
  * added fhir-expansions from the expansions download of the R4B spec
  * added R4B/terminology for other one-off CodeSystem and ValueSet
resources that used to be packaged with the base spec
* use a set instead of a list for codesystem values to workaround
duplicate values in the base spec ResourceType definition
(https://jira.hl7.org/browse/FHIR-34303)

Signed-off-by: Lee Surprenant <[email protected]>
lmsurpre added a commit that referenced this issue Jan 27, 2022
@lmsurpre
issue #2066 - fhir-tools updates for generating code from R4B
08b97ba 
* added R4BModelGeneratorImpl and updated ModelFactory to support that.
* moved current definitions under R4 dir and introduced R4B dir for the
spec artifacts
  * added fhir-expansions from the expansions download of the R4B spec
  * added R4B/terminology for other one-off CodeSystem and ValueSet
resources that used to be packaged with the base spec
* use a set instead of a list for codesystem values to workaround
duplicate values in the base spec ResourceType definition
(https://jira.hl7.org/browse/FHIR-34303)

Signed-off-by: Lee Surprenant <[email protected]>
lmsurpre added a commit that referenced this issue Feb 5, 2022
@lmsurpre
issue #2066 - fhir-tools updates for generating code from R4B
3850aa5 
* added R4BModelGeneratorImpl and updated ModelFactory to support that.
* moved current definitions under R4 dir and introduced R4B dir for the
spec artifacts
  * added fhir-expansions from the expansions download of the R4B spec
  * added R4B/terminology for other one-off CodeSystem and ValueSet
resources that used to be packaged with the base spec
* use a set instead of a list for codesystem values to workaround
duplicate values in the base spec ResourceType definition
(https://jira.hl7.org/browse/FHIR-34303)

Signed-off-by: Lee Surprenant <[email protected]>
lmsurpre added a commit that referenced this issue Feb 15, 2022
@lmsurpre
issue #2066 - fhir-tools updates for generating code from R4B
f52ab19 
* added R4BModelGeneratorImpl and updated ModelFactory to support that.
* moved current definitions under R4 dir and introduced R4B dir for the
spec artifacts
  * added fhir-expansions from the expansions download of the R4B spec
  * added R4B/terminology for other one-off CodeSystem and ValueSet
resources that used to be packaged with the base spec
* use a set instead of a list for codesystem values to workaround
duplicate values in the base spec ResourceType definition
(https://jira.hl7.org/browse/FHIR-34303)

Signed-off-by: Lee Surprenant <[email protected]>
lmsurpre added a commit that referenced this issue Feb 16, 2022
@lmsurpre
issue #2066 - fhir-tools updates for generating code from R4B
4cf3e8b 
* added R4BModelGeneratorImpl and updated ModelFactory to support that.
* moved current definitions under R4 dir and introduced R4B dir for the
spec artifacts
  * added fhir-expansions from the expansions download of the R4B spec
  * added R4B/terminology for other one-off CodeSystem and ValueSet
resources that used to be packaged with the base spec
* use a set instead of a list for codesystem values to workaround
duplicate values in the base spec ResourceType definition
(https://jira.hl7.org/browse/FHIR-34303)

Signed-off-by: Lee Surprenant <[email protected]>
lmsurpre added a commit that referenced this issue Mar 9, 2022
@lmsurpre
issue #2066 - fhir-tools updates for generating code from R4B
fc21ded 
* added R4BModelGeneratorImpl and updated ModelFactory to support that.
* moved current definitions under R4 dir and introduced R4B dir for the
spec artifacts
  * added fhir-expansions from the expansions download of the R4B spec
  * added R4B/terminology for other one-off CodeSystem and ValueSet
resources that used to be packaged with the base spec
* use a set instead of a list for codesystem values to workaround
duplicate values in the base spec ResourceType definition
(https://jira.hl7.org/browse/FHIR-34303)

Signed-off-by: Lee Surprenant <[email protected]>
lmsurpre added a commit that referenced this issue Mar 9, 2022
@lmsurpre
issue #2066 - fhir-tools updates for generating code from R4B
283506e 
* added R4BModelGeneratorImpl and updated ModelFactory to support that.
* moved current definitions under R4 dir and introduced R4B dir for the
spec artifacts
  * added fhir-expansions from the expansions download of the R4B spec
  * added R4B/terminology for other one-off CodeSystem and ValueSet
resources that used to be packaged with the base spec
* use a set instead of a list for codesystem values to workaround
duplicate values in the base spec ResourceType definition
(https://jira.hl7.org/browse/FHIR-34303)

Signed-off-by: Lee Surprenant <[email protected]>
@lmsurpre lmsurpre added the r4b label Apr 4, 2022
lmsurpre added a commit that referenced this issue Apr 8, 2022
@lmsurpre
issue #2066 - fhir-tools updates for generating code from R4B
e196fa4 
* added R4BModelGeneratorImpl and updated ModelFactory to support that.
* moved current definitions under R4 dir and introduced R4B dir for the
spec artifacts
  * added fhir-expansions from the expansions download of the R4B spec
  * added R4B/terminology for other one-off CodeSystem and ValueSet
resources that used to be packaged with the base spec
* use a set instead of a list for codesystem values to workaround
duplicate values in the base spec ResourceType definition
(https://jira.hl7.org/browse/FHIR-34303)

Signed-off-by: Lee Surprenant <[email protected]>
lmsurpre added a commit that referenced this issue Apr 22, 2022
@lmsurpre
issue #2066 - fhir-tools updates for generating code from R4B
a95baa3 
* added R4BModelGeneratorImpl and updated ModelFactory to support that.
* moved current definitions under R4 dir and introduced R4B dir for the
spec artifacts
  * added fhir-expansions from the expansions download of the R4B spec
  * added R4B/terminology for other one-off CodeSystem and ValueSet
resources that used to be packaged with the base spec
* use a set instead of a list for codesystem values to workaround
duplicate values in the base spec ResourceType definition
(https://jira.hl7.org/browse/FHIR-34303)

Signed-off-by: Lee Surprenant <[email protected]>
lmsurpre added a commit that referenced this issue May 12, 2022
@lmsurpre
issue #2066 - fhir-tools updates for generating code from R4B
c7ec030 
* added R4BModelGeneratorImpl and updated ModelFactory to support that.
* moved current definitions under R4 dir and introduced R4B dir for the
spec artifacts
  * added fhir-expansions from the expansions download of the R4B spec
  * added R4B/terminology for other one-off CodeSystem and ValueSet
resources that used to be packaged with the base spec
* use a set instead of a list for codesystem values to workaround
duplicate values in the base spec ResourceType definition
(https://jira.hl7.org/browse/FHIR-34303)

Signed-off-by: Lee Surprenant <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lmsurpre lmsurpre

Labels
P3 Priority 3 - Nice To Have r4b specification
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@prb112 @lmsurpre @vikforfda