Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemd integration is redundant nowadays #33

Open
samcday opened this issue Mar 23, 2024 · 2 comments
Open

systemd integration is redundant nowadays #33

samcday opened this issue Mar 23, 2024 · 2 comments

Comments

@samcday
Copy link

samcday commented Mar 23, 2024

systemd has offered a built-in usb-gadget.target for a while now. Should the existing examples be removed/deprecated with a link to the official approach?

(I guess the [email protected] pattern is still useful, it's just the udev rule + gt.target that is no longer necessary)

pabs3 added a commit to pabs3/gt that referenced this issue Mar 25, 2024
Also reword surrounding language so it still fits on the lines.

The usb-gadget.target is provided by systemd since 242.

Fixes: linux-usb-gadgets#33
pabs3 added a commit to pabs3/gt that referenced this issue Mar 25, 2024
Also reword surrounding language so it still fits on the lines.

The usb-gadget.target is provided by systemd since 242.

Suggested-by: Sam Day (@samcday)
Fixes: linux-usb-gadgets#33
@pabs3
Copy link
Member

pabs3 commented Mar 25, 2024

Sounds reasonable. I've submitted PR #34 to fix this, will merge if @andrzejtp accepts it.

@samcday
Copy link
Author

samcday commented Mar 25, 2024

Nice one! PR looks great to me 👍

pabs3 added a commit to pabs3/gt that referenced this issue Jun 7, 2024
Also reword surrounding language so it still fits on the lines.

The usb-gadget.target is provided by systemd since 242.

Suggested-by: Sam Day (@samcday)
Fixes: linux-usb-gadgets#33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants